PR de correcao #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arquivos criados para o projeto
Mudanças nos arquivos principais
Últimas modificações de estilo e funcionalidades
ghost
requested review from
ghost
commented
Jan 5, 2021
Comment on lines
+1
to
+9
| # Getting Started with Create React App | ||
|
|
||
| This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | ||
|
|
||
| ## Available Scripts | ||
|
|
||
| In the project directory, you can run: | ||
|
|
||
| ### `npm start` |
Author
There was a problem hiding this comment.
No proximo projeto, nao deixem de editar o README com informacoes importantes do projeto, como imagens e link do surge.
Comment on lines
+1
to
+32
| /* .app-container { | ||
| display: flex; | ||
| justify-content: center; | ||
| flex-direction: column; | ||
| align-items: center; | ||
|
|
||
| } | ||
| .chat-container { | ||
| border: 2px solid rgb(56, 56, 56); | ||
| width: 600px; | ||
| height: 750px; | ||
| background-color: rgb(250, 246, 246); | ||
| } | ||
|
|
||
| .chat-footer { | ||
| height: 40px; | ||
| width: 600px; | ||
| display: flex; | ||
| padding: 0 ; | ||
| border: solid; | ||
| } | ||
|
|
||
| .chat-footer div { | ||
| flex-direction: row; | ||
| height: 39px; | ||
| background-color: rgb(248, 240, 230); | ||
| width: 200px; | ||
| border: solid; | ||
| border-width: 0.1px; | ||
| line-height: 39px; | ||
| } */ | ||
|
|
Author
There was a problem hiding this comment.
Codigo comentado pode e deve ser apagado antes da entrega final.
Comment on lines
+38
to
+41
| onSendMessage = () => { | ||
| const message = { | ||
| user: this.state.name, | ||
| text: this.state.text |
Author
There was a problem hiding this comment.
Muito boa a logica dessa funcao! Parabens!
Author
|
Oi, grupo! O projeto de voces foi avaliado como: dentro do esperado! Parabens! Todas as aplicações obrigatórias funcionam muito bem. Queria apenas pedir mais atencao ao README. Colocar informacoes ali e importante pra correcao! Percebi tambem alguns trechos de codigo comentados, lembrem de revisar o codigo antes de enviar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oie! Esse e um PR de correção que nao precisa ser mergeado. A avaliação do projeto esta mais abaixo!